Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metronome count issue #408

Closed
PraveenRanjan18 opened this issue Sep 29, 2020 · 3 comments · Fixed by #414
Closed

Metronome count issue #408

PraveenRanjan18 opened this issue Sep 29, 2020 · 3 comments · Fixed by #414
Assignees
Labels
area-player Related to the audio playback engine. state-accepted This is a valid topic to work on. type-bug 🕷️
Milestone

Comments

@PraveenRanjan18
Copy link

Your environment

  • Version used: AlphaTab v1.0
  • Platform used: JavaScript
  • Rendering engine used: SVG (default)
  • Browser Name and Version: Microsoft Edge(38.14393.2068.0), Google Chrome(Version 85.0.4183.121), Firefox(78.0b4 (32-bit))
  • Operating System and version (desktop or mobile):Windows 10
  • Link to your project:

Expected Results

playing music sheet with 6/4 time signature. Here metronome sound should be 6 times per measure precisely with tempo changes 90 to120 bpm.

Observed Results

metronome sounds somewhere 5 times in some measures ,6 times in measures(that is right), and it also sound 2times in narrow measure.

Steps to Reproduce (for bugs)

while playing music sheet having 6/4 time signature with two tempo. in the beginning(Measure 1 and Measure 2) of sheet it is playing with tempo 90 bpm. and rest of all measures (except measure 1 and 2) is playing with tempo 120 bpm.

  1. select playing area in music sheet by dragging cursor from beginning of Measure 1 to the end of Measure 2.
  2. after selection of Measure 1 and measure 2 click on metronome button to activate it.
  3. then click on play button,
  4. then tempo changes occurs before Completion of Measure 2. (here reproduce the bug)
  5. At that Moment(at the time of tempo changes) previous total metronome count (Measure 1 + Measure 2) is 8. (here reproduce the bug), here total metronome count till end of Measure 2 should be 12 times.
  6. i hear metronome count in Measure 1 is 6 times and in measure 2 it counts only 2 times. here it should be 6 times.
    same testing method i used in entire sheet then i found metronome sound somewhere it count 5,6(that is right), and 2 in narrow measure.

i have attached my music sheet with this bug report.
Chopin.zip

Thanks in advance !

@Danielku15 Danielku15 self-assigned this Oct 3, 2020
@Danielku15 Danielku15 added type-bug 🕷️ area-player Related to the audio playback engine. state-accepted This is a valid topic to work on. labels Oct 3, 2020
@Danielku15
Copy link
Member

Looks like a bug in the generation of metronome events here. The tempo change is processed first, and then the missing metronome ticks since the last event are generated. Correct would be to first generate the metronome events and then apply the tempo change.

@Danielku15 Danielku15 added this to the 1.1 milestone Oct 3, 2020
@PraveenRanjan18
Copy link
Author

Yes Exactly, here it will first generate the metronome events as it required and then apply tempo changes. Thanks @Danielku15 for consider it. hope i will get the latest Alphatab plugin soon with this bug fixes.

@PraveenRanjan18
Copy link
Author

PraveenRanjan18 commented Oct 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. state-accepted This is a valid topic to work on. type-bug 🕷️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants