Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate render requests of partials #1148

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1147

Proposed changes

Prevents requesting the rendering of the same partial multiple times. If the same partial is requested to be rendered multiple times this messes with the positioning of ties.

iOS can sometimes signal the visibility change of the same element multiple times. If this happens things break. By preventing multiple render requests we not only improve performance but also fix the problem with the ties.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Apr 11, 2023
@Danielku15 Danielku15 merged commit 4d146cc into develop Apr 11, 2023
@Danielku15 Danielku15 deleted the feature/fix-missing-ios-tie branch April 11, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ties missing on iOS
1 participant