Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle accidentals on tied notes across bars correctly #485

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Handle accidentals on tied notes across bars correctly #485

merged 1 commit into from
Dec 31, 2020

Conversation

Danielku15
Copy link
Member

Issues

Fixes #472

Proposed changes

For tied notes on a start of bar we check now if it is on the same line as the tie origin and skip the accidental registration in this case.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Dec 31, 2020
@Danielku15 Danielku15 merged commit e9857be into develop Dec 31, 2020
@Danielku15 Danielku15 deleted the feature/tied-accidentals branch December 31, 2020 02:35
This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accidentals added to the wrong note after tie
1 participant
@Danielku15