Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some event data for easier sync with audio. #522

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Added some event data for easier sync with audio. #522

merged 2 commits into from
Jan 16, 2021

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jan 16, 2021 •
edited
Loading

Issues

Fixes #520

Proposed changes

Adds some internal synth info to the events which allows easier synchronization of the synthesizer with an external audio source.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 marked this pull request as ready for review January 16, 2021 16:31
@Danielku15 Danielku15 merged commit 4dfe053 into develop Jan 16, 2021
@Danielku15 Danielku15 deleted the feature/audio-sync branch January 16, 2021 16:32
This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Danielku15