Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MusicXML Slurs and Reworked Repeats #898

Merged
merged 5 commits into from
Jun 12, 2022
Merged

Fix MusicXML Slurs and Reworked Repeats #898

merged 5 commits into from
Jun 12, 2022

Conversation

Danielku15
Copy link
Member

Issues

Fixes #865

Proposed changes

  • Extended MusicXML Tests to perform serialization/deserialization to detect potential errors
  • Fixed slur handling which caused some errors
  • Reworked handling of repeats to align with correct display/playback of GuitarPro (MusicXML tests reported some problematic handling of repeat groups and repeats in general).

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jun 12, 2022
@Danielku15 Danielku15 merged commit 3ce95b8 into develop Jun 12, 2022
@Danielku15 Danielku15 deleted the feature/music-xml-load-error branch June 12, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MusicXML loading error (slurred notes relevant)
1 participant
@Danielku15