refactor: use object instead of many parameters

CodinGame · Nov 6, 2024 · cf73fa3 · cf73fa3
1 parent ac6c0ef
commit cf73fa3
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 15 deletions.
diff --git a/rollup/rollup-metadata-plugin.ts b/rollup/rollup-metadata-plugin.ts
@@ -26,11 +26,13 @@ interface Options {
   ) => { name: string; publicName?: string; priority?: number }
   handle(
     this: PluginContext,
-    group: GroupResult,
-    moduleGroupName: Map<string, string | undefined>,
-    otherDependencies: Set<string>,
-    options: OutputOptions,
-    bundle: OutputBundle
+    params: {
+      group: GroupResult
+      moduleGroupName: Map<string, string | undefined>
+      otherDependencies: Set<string>
+      options: OutputOptions
+      bundle: OutputBundle
+    }
   ): void | Promise<void>
 }
 
@@ -187,7 +189,13 @@ export default ({
 
     await Promise.all(
       groupResults.map(async (group) => {
-        await handle.call(this, group, moduleGroupName, otherDependencies, options, bundle)
+        await handle.call(this, {
+          group,
+          moduleGroupName,
+          otherDependencies,
+          options,
+          bundle
+        })
       })
     )
   }

diff --git a/rollup/rollup.config.ts b/rollup/rollup.config.ts
@@ -864,7 +864,7 @@ export default (args: Record<string, string>): rollup.RollupOptions[] => {
               priority: 1
             }
           },
-          async handle(group, moduleGroupName, otherDependencies, options, bundle) {
+          async handle({ group, moduleGroupName, otherDependencies, bundle }) {
             const customResolutionPlugin = ({
               customLoad
             }: {

diff --git a/rollup/rollup.default-extensions.ts b/rollup/rollup.default-extensions.ts
@@ -103,7 +103,7 @@ export default rollup.defineConfig([
             }
           }),
           metadataPlugin({
-            handle({ directDependencies }, moduleGroupName, otherDependencies, options, bundle) {
+            handle({ group: { directDependencies }, bundle }) {
               const entrypoint = Object.values(bundle).filter(
                 (v) => (v as rollup.OutputChunk).isEntry
               )[0]!.fileName
@@ -191,7 +191,7 @@ ${extensions.map((name) => `  whenReady${pascalCase(name)}()`).join(',\n')}
             }
           },
           metadataPlugin({
-            handle({ directDependencies }, moduleGroupName, otherDependencies, options, bundle) {
+            handle({ group: { directDependencies }, bundle }) {
               const entrypoint = Object.values(bundle).filter(
                 (v) => (v as rollup.OutputChunk).isEntry
               )[0]!.fileName

diff --git a/rollup/rollup.rollup-plugins.config.ts b/rollup/rollup.rollup-plugins.config.ts
@@ -61,7 +61,7 @@ const config: rollup.RollupOptions[] = [
       preferConst: false
     }),
     metadataPlugin({
-      handle({ directDependencies }) {
+      handle({ group: { directDependencies } }) {
         const packageJson: PackageJson = {
           name: `@codingame/monaco-vscode-${path.basename(output)}`,
           ...Object.fromEntries(

diff --git a/rollup/rollup.types.config.ts b/rollup/rollup.types.config.ts
@@ -173,13 +173,11 @@ export default rollup.defineConfig(
                 priority: 1
               }
             },
-            async handle(
-              { name: groupName, exclusiveModules, entrypoints },
+            async handle({
+              group: { name: groupName, exclusiveModules, entrypoints },
               moduleGroupName,
-              otherDependencies,
-              options,
               bundle
-            ) {
+            }) {
               if (groupName === 'main') {
                 return
               }