Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Gatsby 5 migration, deps upgrade and minor fixes #818

Merged
merged 12 commits into from
Dec 16, 2022

Conversation

fturmel
Copy link
Collaborator

@fturmel fturmel commented Dec 7, 2022

Per #750, this upgrades Gatsby to v5 and most deps to their latest major versions. It should allow us to explore the new Slices API and keep improving build times.

Here's the official migration guide for reference: https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v4-to-v5/

Overview

  • Upgrade to node 18, React 18, etc
  • Rewrite GraphQL queries with new sort syntax
  • Upgrade to MDX v2 - this was the majority of the work, a lot has changed
  • Upgrade to react-youtube v10 - some props were renamed
  • Remove @mdx-js/mdx, html-react-parser and gatsby-plugin-meta-redirect

And a few extras things:

Related work to consider?

Up for discussion imo, they could be done in separate PRs.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b8245a9
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/639018c950a131000ab69048
😎 Deploy Preview https://deploy-preview-818--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shiffman
Copy link
Member

shiffman commented Dec 9, 2022

Wow, this is incredible! I'm very excited to check through this and merge. @runemadsen, if you have a few minutes to glance over too let me know!

@fturmel
Copy link
Collaborator Author

fturmel commented Dec 9, 2022

@shiffman Glad you like it!

Quick update, the ESM work previously mentioned seem to have already been merged and will be rolled out this month in Gatsby 5.3 per https://github.com/gatsbyjs/gatsby/pull/37221/files

@runemadsen
Copy link
Contributor

This looks good to me! I haven't done a full user test of the deploy preview, but if everything seems to work, I'm all for the merge.

@shiffman
Copy link
Member

Thank you @runemadsen and @fturmel!

@shiffman shiffman merged commit f5c0b4b into CodingTrain:main Dec 16, 2022
@fturmel fturmel deleted the PR/gatsby-5-migration branch December 17, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants