Exit with an error code when npm/yarn install fails (facebook#1224)

Previously create-react-app exited with 0 after an installation error.
CodingZeal · May 8, 2017 · 469dbf1 · 469dbf1
1 parent 74fa46c
commit 469dbf1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js
@@ -142,10 +142,10 @@ function run(root, appName, version, verbose, originalDirectory) {
   var packageToInstall = getInstallPackage(version);
   var packageName = getPackageName(packageToInstall);
 
-  install(packageToInstall, verbose, function (code, command, args) {
+  install(packageToInstall, verbose, function(code, command, args) {
     if (code !== 0) {
       console.error('`' + command + ' ' + args.join(' ') + '` failed');
-      return;
+      process.exit(1);
     }
 
     checkNodeVersion(packageName);