-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken output format(yaml) prompt #1048
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
thanks @woung717 @KennyDizi output (and input) should be short and concise as possible, if it contains the same data. This saves time and money (fewer tokens). |
That's good to know. If that's so, with the same approach, should we remove the space in the other similar places? @mrT23 |
I think the short and concise prompt principle is good. But modifying the prompt requires a fair amount of testing to make sure it keeps valid format, especially since this project parses structured text (YAML) directly from the LLM response. Maybe it is good to see if it is done correctly, but I think there is not much benefit for the effort. This is just my 2 cent. |
User description
Since the code_feedback field is a property of the YAML output, a colon (:) should follow it. Some LLM models might omit the colon, causing a parsing error.
I observed sometimes that text output in relevant_line property has broken indentation. I think adding multiple line example with indentation could better indent output.
PR Type
bug fix, enhancement
Description
code_feedback
field to correct YAML format inpr_agent/settings/pr_reviewer_prompts.toml
.relevant_line
property to ensure proper formatting.Changes walkthrough 📝
pr_reviewer_prompts.toml
Fix YAML output format and improve indentation
pr_agent/settings/pr_reviewer_prompts.toml
code_feedback
field to correct YAML format.relevant_line
property to ensure properformatting.