Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bitbucket token name and clean up secrets template #1064

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

KennyDizi
Copy link
Contributor

@KennyDizi KennyDizi commented Jul 27, 2024

PR Type

Configuration, Bug fix


Description

  • Fixed an invalid token name in the Bitbucket Server section, changing auth_token to bearer_token for consistency
  • Removed redundant trailing spaces from multiple lines in the configuration file
  • Improved overall formatting and readability of the .secrets_template.toml file

Changes walkthrough

Relevant files
Configuration changes
.secrets_template.toml
Update secrets template and fix Bitbucket token name         

pr_agent/settings/.secrets_template.toml

  • Removed trailing spaces from api_base and deployment_type lines
  • Fixed a typo in the Bitbucket Server section, changing auth_token to
    bearer_token
  • +3/-3     

    @KennyDizi KennyDizi changed the title Fix invalid token name Fix Bitbucket token name and clean up secrets template Jul 27, 2024
    @KennyDizi
    Copy link
    Contributor Author

    🥝 🌍 I've updated the PR description to match the latest commit (a176adb).

    @KennyDizi
    Copy link
    Contributor Author

    PR Analysis 🥳


    ⏰  Estimated effort to review: 1, because this PR contains minor changes to a configuration file template. The changes are straightforward and easy to review, involving the removal of trailing spaces and a small correction to a token name.

    🥇  Score: 95, because the changes improve the consistency and readability of the configuration file. The PR fixes a potential issue with the Bitbucket token name and cleans up the file by removing unnecessary whitespace. These changes are beneficial and do not introduce any new issues.

    🧪  No relevant tests

    🔒  No security concerns identified

    🌔  No key issues to review: This PR makes minor but important changes to the `.secrets_template.toml` file. It corrects the Bitbucket Server token name from `auth_token` to `bearer_token`, which improves consistency with other parts of the configuration. The PR also removes trailing spaces from several lines, enhancing the overall formatting and readability of the file. These changes, while small, contribute to a more maintainable and error-free configuration template.

    @KennyDizi
    Copy link
    Contributor Author

    @mrT23 I've checked the Bitbucket Server provider, and we have a tiny issue with bearer_token. So, I opened this PR, actually. Please look at it and cross-check it.

    @mrT23 mrT23 merged commit 11f85ca into Codium-ai:main Jul 28, 2024
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants