-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for gpt-4-turbo-preview model #820
add support for gpt-4-turbo-preview model #820
Conversation
PR Description updated to latest commit (d064a35)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
pr_agent/settings/configuration.toml
Outdated
model="gpt-4" # "gpt-4-0125-preview" | ||
model_turbo="gpt-4-0125-preview" | ||
model="gpt-4" # "gpt-4-turbo-preview" | ||
model_turbo="gpt-4-turbo-preview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not this.
the default model should be fixed.
I don't want the default model to be dangling, and changing without proper checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any user can change this on his local deployment, if he wishes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing this to my attention. I completely agree with your point.
User description
Use gpt-4-turbo-preview to ensure the latest version is always used.
https://openai.com/blog/new-embedding-models-and-api-updates#updated-gpt-4-turbo-preview
Type
enhancement
Description
gpt-4-turbo-preview
model with a token limit of 128000 to the model token limits configuration.configuration.toml
to usegpt-4-turbo-preview
for bothmodel
andmodel_turbo
fields.Changes walkthrough
__init__.py
Add Support for GPT-4 Turbo Preview Model
pr_agent/algo/init.py
gpt-4-turbo-preview
model with a token limit of128000.
configuration.toml
Update Default Model Settings to GPT-4 Turbo Preview
pr_agent/settings/configuration.toml
gpt-4-turbo-preview
.