Ensure bot doesn't indefinitely hang on an exception in on_ready #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
the
Type: Bug
github-actions
bot
added
the
Category: Core - Other Internals
TrustyJAID
approved these changes
Jul 16, 2023
Jackenmen
changed the title
on_ready
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
As evidenced by the past (#2677, #3663, or, more recently, #6124), we sometimes introduce bugs into this code area, resulting in the bot hanging indefinitely, showing up as online even though it can't be interacted with. This PR aims to properly shut down the bot with a non-zero exit code in such cases.
One unrelated change here is to
fetch_latest_red_version_info()no longer being wrapped with suppress - this is actually already handled by the function itself, in which case it returns(None, None)tuple.Have the changes in this PR been tested?
Yes