Ask for confirmation before setting prefix on first-time setup #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
the
Type: Enhancement
github-actions
bot
added
the
Category: Core - Command-line Interfaces
Flame442
approved these changes
Feb 26, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
…reators#6287) Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
A simple change asking the user to confirm their choice with an example of how the bot would be used with the selected prefix. This might help avoid issues where the user sets their prefix to something such as "!help" since the example usage will then be "!helphelp". I was also considering doing
.endswith("help")with "Are you sure that's correct?" like we have for long prefixes but I figured this more generic solution should work just as well and doesn't require special casing.Have the changes in this PR been tested?
No