Feature/exclude elements notification #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub-Izbicki
requested review from
tkaik,
malaskowski,
plutasnyy and
ernestosiak
Jakub-Izbicki
force-pushed
the
feature/exclude-elements-notification
branch
from
b2c6c98
to
9f61c83
Compare
malaskowski
reviewed
Oct 23, 2018
| } else { | ||
| excludeElementsNotFound = true; | ||
| } | ||
| if (!CollectionUtils.isEmpty(exclude.getNotFoundElements())) { |
There was a problem hiding this comment.
Wouldn't be easier to simply set:
notFoundExcludeElements = exclude.getNotFoundElements();
without this if? In worst case this collection is empty.
There was a problem hiding this comment.
Good catch, thanks. I've fixed it.
Jakub-Izbicki
force-pushed
the
feature/exclude-elements-notification
branch
from
9f61c83
to
b1169dc
Compare
malaskowski
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification that displays when exclude-elements are not found on page now shows what specific elements were not found. Also, the location of text has been changed so it would display below the settings bar.
Motivation and Context
Fixed #372
Screenshots
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.