Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds verbose logging option for the CLI #104

Conversation

dallasjohnson
Copy link
Contributor

When writing tests thrown errors may be difficult to identify.
This PR adds another option to get more detail for thrown errors to help identify what exception was raised to help facilitate writing a test for that exception.

To active this option the tests may run like this:

`npm run-script test  verbose`

Copy link
Collaborator

@MitchPierias MitchPierias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be migrated into ConfigManager in the future, allowing configuration from the .lamgintonrc, and also allow for the specification of the verbose flag to set the ConfigManager's value, therefore overwriting at the CLI level

@MitchPierias
Copy link
Collaborator

@thekevinbrown same issues with the Netlify pipeline...

@thekevinbrown
Copy link
Member

It's actually a different error:

11:36:47 AM: Error: /opt/build/repo/src/cli/lamington-test.ts(16)
11:36:47 AM:  Cannot find name 'args'.

I'll investigate this too.

@thekevinbrown
Copy link
Member

I'd love to unify our logging options and make everything overridable via the CLI, but there's no need to hold this up to do that, so I'm going to go ahead and merge, then we can look into making things fancier later.

@thekevinbrown thekevinbrown merged commit a96ffc8 into CoinageCrypto:master Oct 9, 2019
@dallasjohnson dallasjohnson deleted the feature/Adds-verbose-logging-CLI-option branch October 10, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants