Eosdac working master #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (38 commits) Bump commander from 3.0.2 to 4.0.1 Bump prettier from 1.18.2 to 1.19.1 Bump @types/node from 12.12.3 to 12.12.7 Bump auto-changelog from 1.16.1 to 1.16.2 Bump @types/node from 12.11.7 to 12.12.3 Bump @types/rimraf from 2.0.2 to 2.0.3 Bump @types/node from 12.11.1 to 12.11.7 Bump mocha from 6.2.1 to 6.2.2 Bump @types/chai from 4.2.3 to 4.2.4 Bump glob from 7.1.4 to 7.1.5 Bump @types/node from 12.7.12 to 12.11.1 Bump dotenv from 8.0.0 to 8.2.0 Addressed PR comments. changes after running `npm run format` - include only formatting changes Refactor of the error check assertion to remove duplicate code in the assertions by creating a private function for other assertions to call into. Adds an assertion `assertEOSErrorIncludesMessage` that will assert the error message for an expected `eosio_assert_message_exception` includes the given description. Bump @types/ncp from 2.0.1 to 2.0.2 Formatting changes after running npm run format Build is timing out, but building the docker container takes a while, so let's wait for it. Bump typescript from 3.6.3 to 3.6.4 ... # Conflicts: # src/cli/utils.ts # src/configManager.ts # src/contracts/contract.ts # src/contracts/typeGenerator.ts
… to enable passing tests
…s imports to generated types
* master: Bump typescript from 3.6.4 to 3.7.3
…udes "next_key" in response.
…le `exclude`. Both would be applied while filtering source .cpp files.
…the contract to compile in the form `<contractName>.lamflags` in the same directory and the contract .cpp file.
…r code to allow easier unit testing. Also removes `verbose_logging` from the argsv since it wasn't used.
MitchPierias
approved these changes
Feb 14, 2020
| "axios": "0.19.0", | ||
| "chai": "4.2.0", | ||
| "chalk": "^3.0.0", | ||
| "clarify": "2.1.0", | ||
| "colors": "1.4.0", |
There was a problem hiding this comment.
We do already use colors, but that's okay, might consolidate to only using one in the future
| /** @hidden Maximum number of EOS connection attempts before fail */ | ||
| const MAX_CONNECTION_ATTEMPTS = 8; | ||
| const MAX_CONNECTION_ATTEMPTS = 20; |
There was a problem hiding this comment.
How come all of these timeouts and attempts need to be so high? Are you hitting these numbers?
There was a problem hiding this comment.
I did have have some errors early using the tools which were hard to diagnose since they wouldn't happen on every run. Perhaps this could be set back to 8.
This was referenced Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes I have made for a local version of Lamington to extend functionality for my needs on EOSDAC. Changes include:
-DTRANSFER_DELAY=3to add a build flag forTRANSFER_DELAY = 3to the contract compilation for testing purpose only.debugas a debug level of 0 for none, 1 for minimal which would display the brief output of of each action. 2 for verbose output displaying all the EOSIO transaction output and verbose errors.debugPromiseas a wrapper for any promise to enable which debugging logs (depending on the above debug level).genesis.jsonfile.bailOnFailureso the tests can exit on the first failure as an option.includefor an array of source code files in include rather than having to manually exclude.cppwhich should not be compiled as separate contracts.chalkto help colouring parts of the log output.