Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bios boot #89

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

jnordberg
Copy link
Contributor

This adds minimal system contracts to the testnet running in the container

Will break for eosio 1.7 and earlier, not sure how to handle backwards compat here or if that's a goal at this stage.

@thekevinbrown
Copy link
Member

@jnordberg, thanks!

Given the early state of the tool, we're not targeting backwards compatibility, but I do think it'd be good to tell people with a simple informative error message when they try to use it for 1.7 or earlier.

Other than that the only other thing I'm not sure on is a question about whether the 1 second sleep is necessary. What is that there to do?

@jnordberg
Copy link
Contributor Author

The sleep is because I was getting intermittent errors when creating the system accounts, not sure exactly why it helps but it does 🤷‍♂

Another thing that occurred to me when using this is that it might be good to omit calling the eosio init by default and have a flag in .lamingtonrc to whether to enable it

Copy link
Member

@thekevinbrown thekevinbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like I said before, I don't love using sleep to work around race conditions, but sometimes there isn't a better option. In this case it'll be better to keep moving than to try to be a perfectionist.

Thank you again for the contribution!

@thekevinbrown thekevinbrown merged commit a5b162c into CoinageCrypto:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants