Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to the console output during the build #96

Conversation

dallasjohnson
Copy link
Contributor

This is a small PR to dip my toe in the water for contributing to an NPM project. I have a few more changes coming through using the lamington code locally on my projects for which I will open separate PRs so as to provide more atomic changes into the project if you guys see them to be valuable changes.


When building Lamington on a project with multiple contracts it is difficult to know which contracts are being built during the build/type generation steps and therefore which if any files should be excluded in the .lamingtonrc file to help speed up the build process.

This change adds more details of which cpp files are being built and which are being type generated to help with this problem and where the output files are being placed.

…ration so we can tell which contracts are currently being built.
Copy link
Collaborator

@MitchPierias MitchPierias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Just a consideration for next time, we typically use template literals when constructing strings. I need to write a style guide...

@MitchPierias MitchPierias merged commit 2f74cd0 into CoinageCrypto:master Oct 8, 2019
@dallasjohnson dallasjohnson deleted the feature/Add-more-context-to-console-logging-during-build branch October 8, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants