Helpdev package became a mandatory dependency, make it optional #182
Comments
SomberNight
added a commit
to spesmilo/electrum
that referenced
this issue
Jun 4, 2019
qdarkstyle 2.7 pulls in new dependencies see ColinDuquesnoy/QDarkStyleSheet#182
|
We can study this in the v2.8, as we will introduce qtpy as mandatory to simplify many things in the code (as seen in the develop branch). As we won't use directly the bindings, the other functions of helpdev won't be needed except for reports. |
cculianu
added a commit
to Electron-Cash/Electron-Cash
that referenced
this issue
Jun 4, 2019
Taken from spesmilo#046518d7f73fdee30fb974b283780fc4691a614e 2.6.8 is well tested and looks good. Other earlier versions may have bugs. QDarkStyle 2.7 pulls in some dependencies, see ColinDuquesnoy/QDarkStyleSheet#182 Ergo, we restrict to exactly 2.6.8
cculianu
added a commit
to simpleledger/Electron-Cash-SLP
that referenced
this issue
Jun 4, 2019
Taken from spesmilo#046518d7f73fdee30fb974b283780fc4691a614e 2.6.8 is well tested and looks good. Other earlier versions may have bugs. QDarkStyle 2.7 pulls in some dependencies, see ColinDuquesnoy/QDarkStyleSheet#182 Ergo, we restrict to exactly 2.6.8
dpizetta
changed the title
SomberNight
added a commit
to SomberNight/electrum
that referenced
this issue
Jun 3, 2020
Previously we stuck with version 2.6.8 as that had no deps but later versions introduced several deps. However, now latest version only has two dependencies (one of which has the same maintainer). Futher, there are some bugs with 2.6.8 when used with new Qt, e.g. with dropdowns that I want fixed (which it is in the newer ones). related ColinDuquesnoy/QDarkStyleSheet#182
SomberNight
added a commit
to spesmilo/electrum
that referenced
this issue
Jun 3, 2020
Previously we stuck with version 2.6.8 as that had no deps but later versions introduced several deps. However, now latest version only has two dependencies (one of which has the same maintainer). Futher, there are some bugs with 2.6.8 when used with new Qt, e.g. with dropdowns that I want fixed (which it is in the newer ones). related ColinDuquesnoy/QDarkStyleSheet#182
dpizetta
added a commit
that referenced
this issue
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
helpdevpackage was introduced as a mandatory dependency for 2.7, in #147Along with
helpdev, this pulls inimportlib-metadata,psutil, andzippas indirect dependencies.It seems to me that
helpdevis only used for diagnostics/bug reports.Would it be possible to turn it into an optional dependency instead?
The text was updated successfully, but these errors were encountered: