Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The style of active and non active items in table and list views is the same #209

Closed
jnsebgosselin opened this issue Nov 12, 2019 · 11 comments
Assignees
Milestone

Comments

@jnsebgosselin
Copy link

Description

There is actually no distinction in the style of active and not active items in table and list views. Below is an example for the project plugin and keyboard shortcuts preference dialog in Spyder using the darkstyle and windows vista style.

I think this would be a good idea to define a separate style for the not active items of table and list views.

image

image

@goanpeca
Copy link
Collaborator

@dpizetta with the upcoming release of spyder 4 it would be great to have a new release of QDark, any thoughts?

@dpizetta
Copy link
Collaborator

@goanpeca sorry for the late response. About the release, yes, we can schedule it for the end of this month, what you think?

@dpizetta dpizetta self-assigned this Nov 19, 2019
@goanpeca
Copy link
Collaborator

Yes, that would be great!

@dpizetta
Copy link
Collaborator

I'll be working on qdark at night for those two weeks :)

@dpizetta dpizetta added this to the 2.8 milestone Jan 13, 2020
@dpizetta
Copy link
Collaborator

Sorry again about it, working on this :) Tks

@dpizetta
Copy link
Collaborator

In the native Linux theme, ubuntu 18.04/gnome it does not provide an identifier for focus on tree and list views. I will try to use some similar to the table, it looks nice and it is quite similar we have been using for buttons. See some gif below:

list-tree-view-in-linux-dark

list-tree-view-in-linux--nodark

@dpizetta
Copy link
Collaborator

@jnsebgosselin in your image from using qdark the list/tree border do not light up when selected/hover? See my example below. Tks

@jnsebgosselin
Copy link
Author

@jnsebgosselin in your image from using qdark the list/tree border do not light up when selected/hover? See my example below. Tks

Yes the list/tree border does highlight on mouse hover.

@dpizetta dpizetta modified the milestones: 2.8, 2.9 Jan 20, 2020
@dpizetta
Copy link
Collaborator

I want to change some things on those views, but they are not so easy to implement (actually, to understand and insert the right thing in the right place), so I will change this to the next version.

@dpizetta dpizetta removed this from the 2.9 milestone Mar 29, 2021
@dpizetta
Copy link
Collaborator

May @isabela-pf has a good idea of what color to use here. @juanis2112 @ccordoba12 thoughts?

Currently, it is like this:

list-qdark

Maybe we can keep the same as the hovering one.

For comparison, an example of VSCode too.

list-selection

@dpizetta
Copy link
Collaborator

The result is this
table-views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants