Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme? #240

Closed
hmaarrfk opened this issue Sep 26, 2020 · 5 comments
Closed

Light theme? #240

hmaarrfk opened this issue Sep 26, 2020 · 5 comments

Comments

@hmaarrfk
Copy link
Contributor

I know the whole point of this is to have a good looking dark theme, but many of the style changes you've done look quite good (increasing the size of certain elements and whatnot), so I was wondering if there was any interest in adding a "light" theme that would match the dark theme you've created?

Is there one already available? Maybe I just can't find it.

Thanks for the consideration!

@ccordoba12
Copy link
Collaborator

We're thinking to create a light theme based on this one for Spyder 5. I hope we have enough time for that.

@dpizetta
Copy link
Collaborator

Just to document, Spyder team is working on this: #252

@dpizetta
Copy link
Collaborator

Implemented in #268

@mgrojo
Copy link
Contributor

mgrojo commented Mar 29, 2021

I'm not sure if I should open a new issue or not, but I'll do it if I'm said to.

I've tried to add the new light style to DB Browser for SQLite. I want to provide three options: follow the desktop style, dark style and light style. I cannot add these two options with qdarkstyle at the same time. My impression is that the Qt or cmake generation for the resources are overlapped due to usage of the same file name for both savours. This is what I've changed in CMakeLists.tst to include both styles:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 91573df6..22b1dbca 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -274,7 +274,8 @@ set(SQLB_RESOURCES
        src/translations/flags/flags.qrc
        src/translations/translations.qrc
        src/certs/CaCerts.qrc
-       src/qdarkstyle/style.qrc
+       src/qdarkstyle/light/style.qrc
+       src/qdarkstyle/dark/style.qrc
 )
 
 set(SQLB_MISC

Only the last listed qrc can be used, probably because this file is generated twice: qrc_style.cpp

Which is the recommended way to include both? The instructions in the README have not been updated, by the way.

@mgrojo
Copy link
Contributor

mgrojo commented Mar 30, 2021

I've worked around this problem renaming style.qrc to lightstyle.qrc and darkstyle.qrc accordingly. Please, let me know if there is a better way to do this, specially for not needing to change QDarkStyleSheet as provided.

mgrojo added a commit to sqlitebrowser/sqlitebrowser that referenced this issue Mar 31, 2021
Thanks to a new light style provided by QDarkStyleSheet in v3.0.rc
(9eea545) we can add a new light style option.

`qdarkstyle/dark/style.qrc` had to be renamed to
`qdarkstyle/dark/darkstyle.qrc` and `qdarkstyle/light/style.qrc` to
`qdarkstyle/light/lightstyle.qrc` in order to include both as resources.

See issues:
- ColinDuquesnoy/QDarkStyleSheet#240
- ColinDuquesnoy/QDarkStyleSheet#273
- #2558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants