Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons size problems #248

Closed
RinnetenseiQ opened this issue Nov 29, 2020 · 3 comments
Closed

Buttons size problems #248

RinnetenseiQ opened this issue Nov 29, 2020 · 3 comments
Assignees
Milestone

Comments

@RinnetenseiQ
Copy link

I really like this library that sets up a dark theme for PyQt apps. However, I ran into some problem with the size of the widgets, in particular with the buttons. Screenshots are attached. This is bug? Can I fix it somehow? Please keep in mind that I am quite inexperienced in writing PyQt applications, and in Python in general.

[Versions from your environment]

  • QDarkStyle:
  • OS: Windows 10
  • Python: 3.7

[If used, please inform their versions]

  • PyQt: PyQt5==5.12.3

Language

[Python]
изображение_2020-11-29_231715

image
image

@dpizetta dpizetta self-assigned this Dec 1, 2020
@dpizetta
Copy link
Collaborator

dpizetta commented Dec 1, 2020

Hi @RinnetenseiQ we are happy that you are using QDarkStyle.

About the issue, what types of buttons you are using? You should use tool buttons for general ones. Push buttons have a minimum size set (like Ok, Cancel, Yes, etc).

This link can help you to decide.

@RinnetenseiQ
Copy link
Author

Hi @RinnetenseiQ we are happy that you are using QDarkStyle.

About the issue, what types of buttons you are using? You should use tool buttons for general ones. Push buttons have a minimum size set (like Ok, Cancel, Yes, etc).

This link can help you to decide.

Thank for your answer.
But the difference in button decoration between themes(Fusion, Windows vs QDarkStyle) is obvious from screenshots.
What is the reason for this deviation from the standard? Or did it happen by accident?

@dpizetta
Copy link
Collaborator

We want to apply the fixed size only for dialogs, fixed in the develop branch, tks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants