Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI crashes when selecting all the text and hitting backspace #187

Open
ColinPitrat opened this issue Mar 26, 2021 · 2 comments
Open

GUI crashes when selecting all the text and hitting backspace #187

ColinPitrat opened this issue Mar 26, 2021 · 2 comments

Comments

@ColinPitrat
Copy link
Owner

For example in load/save, select save, type "a" as the filename then select it with shift-left, then press backspace.
The GUI crashes.
@ColinPitrat
Copy link
Owner Author

Interestingly, shift-home then backspace works fine.

ColinPitrat added a commit that referenced this issue Mar 26, 2021
@ColinPitrat
Fix GUI crash. #187
ffe05f8
@ColinPitrat
Copy link
Owner Author

Fixed in ffe05f8

Will keep this issue open to consider:

  • adding tests on this code
  • factorizing wg_editbox and wg_textbox
  • looking for similar bugs with this code: the handling of selection is fishy and may hide other issues. Refactoring may be desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ColinPitrat