Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/badge integration #353

Open
wants to merge 20 commits into
base: development
Choose a base branch
from
Open

Conversation

andre-tm-hui
Copy link
Contributor

@andre-tm-hui andre-tm-hui commented Feb 5, 2023

Created Badge and BadgeDto entities, and updated tests to ensure JSONs from the API are parsed correctly.

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #353 (14d984e) into development (db8283d) will decrease coverage by 0.12%.
The diff coverage is 12.94%.

❗ Current head 14d984e differs from pull request most recent head f7df4ee. Consider uploading reports for the commit f7df4ee to get more accurate results

@@               Coverage Diff               @@
##           development     #353      +/-   ##
===============================================
- Coverage        65.65%   65.53%   -0.12%     
===============================================
  Files              161      162       +1     
  Lines             4067     4074       +7     
===============================================
  Hits              2670     2670              
- Misses            1397     1404       +7     
Impacted Files Coverage Δ
lib/domain/crowdaction/crowdaction.dart 94.73% <ø> (ø)
lib/domain/profile/profile.dart 100.00% <ø> (ø)
.../infrastructure/auth/firebase_auth_repository.dart 40.20% <0.00%> (-4.96%) ⬇️
lib/presentation/auth/auth_screen.dart 2.00% <0.00%> (ø)
...rowdaction_details/crowdaction_details_screen.dart 0.00% <0.00%> (ø)
...ction_details/widgets/crowdaction_description.dart 0.00% <0.00%> (ø)
...on_details/widgets/crowdaction_details_banner.dart 84.37% <ø> (-0.92%) ⬇️
lib/presentation/home/widgets/password_modal.dart 80.59% <0.00%> (ø)
...ation/shared_widgets/expandable_markdown_text.dart 0.00% <0.00%> (ø)
lib/presentation/themes/markdown_stylesheet.dart 0.00% <0.00%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Xazin
Xazin previously approved these changes Feb 23, 2023
@wizlif
Copy link
Collaborator

wizlif commented Mar 18, 2023

@andre-tm-hui Please fix conflicts and merge.

@andre-tm-hui
Copy link
Contributor Author

Conflicts fixed and ready for merge. Had to change the class name from Badge to CollActionBadge since a Badge class already exists in flutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants