Skip to content

Commit

Permalink
Fix incorrect order of message arguments
Browse files Browse the repository at this point in the history
The 'pictureurl' message is handled in ChildSession::contentControlEvent,
which relies on the order of the arguments.
In commit 60d9a9c (Implement remote
multimedia insertion support, 2024-11-19), I incorrectly modified the
order, trying to unify it between nearby calls. Fix it here.

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I612973e1b8aa245a601d3053e516b67007482a69
  • Loading branch information
mikekaganski authored and vmiklos committed Nov 26, 2024
1 parent 3fb9540 commit e729f7e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion browser/src/map/handler/Map.FileInserter.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ L.Map.FileInserter = L.Handler.extend({
}

if (e.urltype == "graphicurl" && section && section.sectionProperties.picturePicker) {
app.socket.sendMessage('contentcontrolevent name=' + encodeURIComponent(e.url) + ' type=pictureurl');
// The order argument is important
app.socket.sendMessage('contentcontrolevent type=pictureurl name=' + encodeURIComponent(e.url));
} else {
app.socket.sendMessage('insertfile name=' + encodeURIComponent(e.url) + ' type=' + e.urltype);
}
Expand Down

0 comments on commit e729f7e

Please sign in to comment.