cool#9992 doc sign: add signature creation cypress test #10259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails with commit 0c1cd8c (cool#9992 doc sign: set the view's sign cert from the WOPI UserPrivateInfo, 2024-10-07) reverted. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ib2320f73c7a21b11d3f237d77ba99bc35ba3ca5e
|
@caolanm could you please review this? Thanks. The certs are generated with that core.git script, but I'll add something to the SDK on how to do this would cloning a git repo a bit later. |
caolanm
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails with commit 0c1cd8c (cool#9992
doc sign: set the view's sign cert from the WOPI UserPrivateInfo,
2024-10-07) reverted.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Ib2320f73c7a21b11d3f237d77ba99bc35ba3ca5e