cool#9992 doc sign: add UI to sign PDF files #10431
Conversation
Open a PDF file, it is loaded into a read-only Draw view, so the File menu has no signing menu item to sign the document. There are some menu items, but all of those are actions, and one of those are inserting a comment: so probably the intent is to avoid not necessary modifications to the PDF file (like delete the only bitmap on the draw page), than to actually avoid modifying the document. Similar to how we have an allowlist for actions, add an allowlist for UNO commands which are OK to dispatch in read-only mode: just have the signature command there for now. In the future, we may want to revisit this to also have a more strict read-only mode without commenting/signing, but treating signing similar to commenting is probably good enough for now. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ib3b396f110cd2d99dbb5d4704f5733bb135f891e
but passes for me locally (failed once, but then passed..), retry. |
It seems that the primary problem is that the viewport is scroll, so the tab dialog can be scrolled and cypress scrolls to the middle by default. Unfortunately scrolling to the buttons that would do tab switching doesn't seem to help: as soon as the button is available, cypress clicks on it, and somehow that's too early. Drop 3 no more needed waits and add back 2 elsewhere, now this test passes for me locally several times in a row. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I90901750c812ffec1914ab09877d71c0fabf7996
|
https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/2289/console failed again in:
let me try to make that more stable, then. |
|
@caolanm could you please review this? Thanks. With this, interactive PDF signing works for me in COOL. The 2nd commit tries to improve the stability of that cypress test -- I don't see any change to the stability with or without the 1st commit. |
| @@ -13,25 +13,21 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'File Property Tests', func | |||
|
|
|||
| it('Add File Description.', function() { | |||
| writerHelper.openFileProperties(); | |||
| // Too early click on the 'Description' button would have no effect. | |||
| cy.wait(500); | |||
| cy.cGet('#tabcontrol-2').click(); | |||
There was a problem hiding this comment.
I imagine its not as straightforward as the button is disabled until scrolled into place and async enabled just after cypress clicks on it.
There was a problem hiding this comment.
Hm, possible, I'll keep that in mind next time we run into something like this. I know click() loudly fails when you try to click on something not visible, but possibly it's different for the "visible, but disabled" case.
Open a PDF file, it is loaded into a read-only Draw view, so the File
menu has no signing menu item to sign the document.
There are some menu items, but all of those are actions, and one of
those are inserting a comment: so probably the intent is to avoid not
necessary modifications to the PDF file (like delete the only bitmap on
the draw page), than to actually avoid modifying the document.
Similar to how we have an allowlist for actions, add an allowlist for
UNO commands which are OK to dispatch in read-only mode: just have the
signature command there for now.
In the future, we may want to revisit this to also have a more strict
read-only mode without commenting/signing, but treating signing similar
to commenting is probably good enough for now.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Ib3b396f110cd2d99dbb5d4704f5733bb135f891e