cool#9992 doc electronic sign: actually sign the hash in a popup #10603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open an PDF in Draw, Insert -> Electronic signature, the doc hash is sent to ESignatureBaseUrl, but we don't attempt to sign it. The actual signing happens using a HTML page provided by eIDEasy, so open that in a popup. We can avoid polling for the signature result by listening for postmessages: the signing popups sends us a postmessage on completion. This is the same mechanism that's used by the SignatureJS npm library, developed by eIDEasy (but don't use that here, since it would pull in a number of dependencies since it doesn't use the fetch() API). Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I10902ec6868a64f250fe5afdd0cf9ba36a2f63e6
|
@caolanm could you please review this? Thanks. If you want to try it, see #9992 (comment) for a test config. Initially I thought I need to poll the server if we have a result or need to wait more, but turns out there is a postmessage we can listen to, which I consider nice. |
caolanm
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open an PDF in Draw, Insert -> Electronic signature, the doc hash is
sent to ESignatureBaseUrl, but we don't attempt to sign it.
The actual signing happens using a HTML page provided by eIDEasy, so
open that in a popup.
We can avoid polling for the signature result by listening for
postmessages: the signing popups sends us a postmessage on completion.
This is the same mechanism that's used by the SignatureJS npm library,
developed by eIDEasy (but don't use that here, since it would pull in a
number of dependencies since it doesn't use the fetch() API).
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: I10902ec6868a64f250fe5afdd0cf9ba36a2f63e6