calc: update viewedRectangle on status message #10651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please solve conflict and rebase to pass CI :) |
viewedRectangle was not properly being updated when new document sizes were received via status message. This sometimes caused the view to not scroll properly when using arrow keys to select cells just after opening a file. Some test have been updated due to changed scrollbar sizes, since the bar size depends on the document size. Tried to add a cypress test but couldn't get the error to trigger on cypress. Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com> Change-Id: I48058b0ac5df70ca14a0a7c32e1f9b697fa37f81
JaumePujantell
force-pushed
the
private/jaume/calc-viewedrectangle
branch
from
ab860f8 to
829999f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewedRectangle was not properly being updated when new document sizes
were received via status message. This sometimes caused the view to not
scroll properly when using arrow keys to select cells just after opening
a file.
Some test have been updated due to changed scrollbar sizes, since the
bar size depends on the document size.
Tried to add a cypress test but couldn't get the error to trigger on
cypress.
Signed-off-by: Jaume Pujantell jaume.pujantell@collabora.com
Change-Id: I48058b0ac5df70ca14a0a7c32e1f9b697fa37f81