private/pedro/stylesview ui enhancements #10736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pedropintosilva
commented
Dec 16, 2024
pedropintosilva
commented
- Writer: Stylesview: Remove additional space above 1st preview's row
- Writer: Stylesview: Border should be included in total height
pedropintosilva
force-pushed
the
private/pedro/stylesview-ui-enhancements
branch
from
40a987d to
6dbaf74
Compare
Better to vertical align image previews to the top. This way, we avoid additional space between he container and the previews Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I8a8b0e4a2a3f5d1d48946f026cfd18cd921411b2
This way we can make sure the Stylesview container doesn't become to bulky. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Iad7a2bb2226e99d0840d0aba437f4dcde9bce634
pedropintosilva
force-pushed
the
private/pedro/stylesview-ui-enhancements
branch
from
6dbaf74 to
385b174
Compare
Darshan-upadhyay1110
approved these changes
Dec 21, 2024
Darshan-upadhyay1110
deleted the
private/pedro/stylesview-ui-enhancements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.