add missing files to the install dir #10752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timar
force-pushed
the
private/timar/tileworker
branch
from
b90349b to
0cc748a
Compare
We need
- src/layer/tile/CanvasTileUtils.js (included from TileWorker.js)
and
- src/layer/tile/TileWorker.js (because we have
`this._worker = new Worker('src/layer/tile/TileWorker.js');`
in bundle.js
These files have to be present separately in install dir.
Whether it's a permanent solution, or a temporary hack, I don't know.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9d0d21463be0cef10ff95a0cd80226a5fc29fa75
timar
force-pushed
the
private/timar/tileworker
branch
from
0cc748a to
2d17ebd
Compare
|
Let's try this in red CODE first. Unfortunately, because of this bug, the TileWorker optimization patches have never been tested anywhere in production, only on developer's computer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need
this._worker = new Worker('src/layer/tile/TileWorker.js');in bundle.jsThese files have to be present separately in install dir. Whether it's a permanent solution, or a temporary hack, I don't know.
Change-Id: I9d0d21463be0cef10ff95a0cd80226a5fc29fa75