Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wopi: add UserCanOnlyComment option #10768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JaumePujantell
Copy link

If UserCanWrite and UserCanOnlyComment are set to true the document is
opened in comment only mode. If UserCanWrite is false,
UserCanOnlyComment is ingnored.

Signed-off-by: Jaume Pujantell jaume.pujantell@collabora.com
Change-Id: I3417aadc428e079bb1533e2432ea60a1e62d03fb

If UserCanWrite and UserCanOnlyComment are set to true the document is
opened in comment only mode. If UserCanWrite is false,
UserCanOnlyComment is ingnored.

Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I3417aadc428e079bb1533e2432ea60a1e62d03fb
@hfiguiere
Copy link
Contributor

My only concern here is that UserCanOnlyComment is presented as a higher permission of UserCanWrite. So if the integration return UserCanOnlyComment (along with UserCanWrite) to a version of COOL that doesn't understand it, it will basically grant the write permission, while I think in that case it should revert to read only.

I believe that the proper thing would be to set UserCanOnlyComment to allow commenting, without UserCanWrite being set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

2 participants