slideshow: backport to 24.04 branch #10773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcecchetti
changed the title
hcvcastro
approved these changes
Dec 19, 2024
If the slideshow is started when impress is in notes view mode slides have a wrong size and content is messed up. Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com> Change-Id: I6621f8d756f2c6b6b1bcf478fb50be0fd83d25db
This is a follow up since previous patch has a problem when presenter console is started in Firefox when Impress is in notes view mode. Oddly, it seems that presentation information are requested but the reply with the info never reaches CanvasTileLayer._onMessage. Anyway I can see that the reply is sent by the core. Since I'm not able to understand the root cause, I implemented a simple workaround by delay the presenter console start by 500ms. In order to be safer I decided to apply the same delay also when we present without the console. Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com> Change-Id: I941419b3d33095608973af18aab9df2b767a02f4
mcecchetti
force-pushed
the
private/marco/slideshow-backport-to-20-24
branch
from
34e0cee to
b4d44b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit: