Focus inside input field on show show input modal #10789
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Dec 26, 2024
| @@ -1570,6 +1570,9 @@ L.Control.UIManager = L.Control.extend({ | |||
| that.closeModal(dialogId); | |||
| }} | |||
| ]); | |||
|
|
|||
| // focus on input modal on show | |||
| document.getElementById('input-modal-input').focus(); | |||
There was a problem hiding this comment.
We should try to avoid getElementById where possible.
Also: why not put this inside showModal function? then in all places where we show modal we will focus it, not only in this case
There was a problem hiding this comment.
if we have to, better to query inside container: container.querySelector('#id')
that makes us sure we will not get element from some other place than our current component/dialog
Darshan-upadhyay1110
force-pushed
the
private/darshan/fix-focus-input-modal-on-show
branch
from
73fe57e to
512bb90
Compare
Darshan-upadhyay1110
force-pushed
the
private/darshan/fix-focus-input-modal-on-show
branch
2 times, most recently
from
1276de9 to
1a69611
Compare
- fix regression caused by #10795 - need to handle both tabcontrol element and single init focus element Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I5a29ddf7b4562221fc8a6c574a775d2a2e9180a8
Darshan-upadhyay1110
force-pushed
the
private/darshan/fix-focus-input-modal-on-show
branch
from
1a69611 to
49648c3
Compare
|
can we have some cypress test which will check that initial focus? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I5a29ddf7b4562221fc8a6c574a775d2a2e9180a8
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay