Temporary Poster Background #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite on image cache generation FileStream
bagusnl
added
Area: Launcher
Qodana for .NET2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This reverts commit 7e504b2.
Cryotechnic
requested changes
Nov 23, 2024
|
|
||
| // TODO: Use FallbackCDNUtil to get the sprites | ||
| _gamePosterPath = await ImageLoaderHelper.GetCachedSpritesAsync(FallbackCDNUtil.TryGetAbsoluteToRelativeCDNURL(config.ZonePosterURL, "metadata/"), default); | ||
| //_gamePosterPath = await ImageLoaderHelper.GetCachedSpritesAsync(FallbackCDNUtil.TryGetAbsoluteToRelativeCDNURL(config.ZonePosterURL, "metadata/"), default); |
There was a problem hiding this comment.
Remove if not in use, or uncomment if you commented it for testing
There was a problem hiding this comment.
Intentional as the code might be used again if the local loading method is removed or we want to use different posters for OOBE
|
Merging as no more review came :sadge: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
Use poster as temporary background when requested background is not yet downloaded.
New background retrieval mechanism:
Due to the poster having slight transparency, the switching looks a wee bit janky
This PR also contains IOException fixes especially for background loading and image cache processing (really noticeable when user uses Waifu2X)
PR Status :