Preview 1.82.5 Release #618

bagusnl · 2024-12-09T15:12:46Z

What's new? - 1.82.5

[Fix] Various weird errors that might be caused by Optimization preference, by @neon-nyan & @bagusnl
- We are noticing quite odd behaviors with some functions, critically Sophon and Http downloader and also SevenZipExtractor modules
- This error does not seem to be reproducible in Debug environment, but recent development by @neon-nyan found that setting the optimization profile to Speed may cause compiler over optimization in certain areas.
- This fix set the project's compiler optimization to Size instead (which is the default .NET behaviour).
- If this fixes those errors that were problematic then good, if not then we have to rethink about those problematic modules...
[Fix] Exceptions in Carousel methods, by @bagusnl
- Third time the charm 🤞
[Fix] DirectoryNotFound exception in HTTP module, by @bagusnl
[Imp] Only recreate shortcut once, by @bagusnl
- Please, no more re-pinning my shortcut...
[Fix] App crash when finalizing update, by @bagusnl
[Fix] Prevent image load fails when waifu2x failes to load / nulled, by @shatyuka
[Fix] (Attempt to) Fix corruption when extracting packages via SevenZipExtractor, by @neon-nyan

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

Also disable Reflection completely

third time the charm (?)

…atus

its meant to fail

To prevent need to re pin all shortcuts

…exist was specified

Splitting some codes into several methods: - CreateShortcut() - Create shortcuts from desired path - GetIconLocationPaths() - Get Icon Location Paths and some attributes like appProductName to be used as AUMID for Toast Notification feature

Due to unified Game Repair and Cache Update into a single base class, this causes the message from Game Repair to appear instead Cache Update ones

100% reviewed source file: 'en_US.json' on 'es_419'.

100% reviewed source file: 'en_US.json' on 'zh_CN'.

CollapseLauncher/Classes/GameManagement/GameVersion/BaseClass/GameVersionBase.cs

@@ -1140,7 +1140,21 @@
            return false;
        }

-        private bool IsDiskPartitionExist(string path) => !string.IsNullOrEmpty(path) && !string.IsNullOrEmpty(Path.GetPathRoot(path)) && new DriveInfo(Path.GetPathRoot(path) ?? string.Empty).IsReady;
+        private bool IsDiskPartitionExist(string path)


CollapseLauncher/Classes/GameManagement/GameVersion/BaseClass/GameVersionBase.cs

@@ -1140,7 +1140,21 @@
            return false;
        }

-        private bool IsDiskPartitionExist(string path) => !string.IsNullOrEmpty(path) && !string.IsNullOrEmpty(Path.GetPathRoot(path)) && new DriveInfo(Path.GetPathRoot(path) ?? string.Empty).IsReady;
+        private bool IsDiskPartitionExist(string path)


CollapseLauncher/Classes/Helper/WindowUtility.cs

@@ -283,6 +285,45 @@
            }
        }

+        private static NotificationService? _currentToastNotificationService;
+        internal static NotificationService? CurrentToastNotificationService


CollapseLauncher/Classes/Helper/WindowUtility.cs

+            get
+            {
+                // If toast notification service field is null, then initialize
+                if (_currentToastNotificationService == null)


CollapseLauncher/Classes/Helper/WindowUtility.cs

+                    _currentToastNotificationService = new NotificationService(ILoggerHelper.GetILogger("ToastCOM"));
+
+                    // Get string for AumId registration
+                    if (!string.IsNullOrEmpty(appAumIdName))


CollapseLauncher/XAMLs/MainApp/MainPage.xaml.cs

+                            WindowUtility.CurrentToastNotificationService?.CreateToastNotifier();
+                        notifier.Show(notificationService);
+                    }
+                    catch { }


CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBESelectGame.xaml.cs

@@ -1,13 +1,17 @@
 using CollapseLauncher.Helper;
 using CollapseLauncher.Helper.Background;
+using CollapseLauncher.Helper.Database;


CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBESelectGame.xaml.cs

+            SpawnGreetingsToastNotification(categorySelected, regionSelected);
+        }
+
+        private void SpawnGreetingsToastNotification(string? gameName, string? regionName)


CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBESelectGame.xaml.cs

+            SpawnGreetingsToastNotification(categorySelected, regionSelected);
+        }
+
+        private void SpawnGreetingsToastNotification(string? gameName, string? regionName)


CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBESelectGame.xaml.cs

+
+        private void SpawnGreetingsToastNotification(string? gameName, string? regionName)
+        {
+            if (!string.IsNullOrEmpty(gameName)


100% reviewed source file: 'en_US.json' on 'ja_JP'.

Inconsistent enable state?

sentry-io · 2024-12-11T12:22:25Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ **System.IO.IOException: IO_SharingViolation_File, **************AppData\Roaming\Microsoft\Windows\Start Menu\Programs\C... Program.cs in void MainEntryPoint.TryCleanupFal... View Issue

_{Did you find this useful? React with a 👍 or 👎}

Cryotechnic and others added 26 commits December 8, 2024 09:42

[skip ci] Update README.md

35b38de

[skip ci] [AppVeyor] Disable InnoSetup generation

725d315

Use Size optimization instead of Speed

910fc2c

Also disable Reflection completely

[Repair] Fix FileNotFound exception in TryUnassignReadOnlyFiles

88c1c62

[HomePage] Fix ArgumentException in Carousel methods

c3b1c49

third time the charm (?)

[CDN] Fix false Sentry reporting error on FallbackCDNUtil.TryGetUrlSt…

722e7af

…atus

[CDN] Remove sentry reporting from try mechanism

336379b

its meant to fail

[HomePage] Fixed ObjectDisposedException on CarouselToken

44e777b

[HTTP DownloadClient] Ensure directory creation and throw early on null

284c6e2

Only recreate all shortcut once

d28969d

To prevent need to re pin all shortcuts

[EncTool/Sophon] Update Protobuf

c7a45ae

[GameVersionBase] Fix System.IO.IOException: A device which does not …

14ca7c9

…exist was specified

Bump version <1.82.5>

db790d9

Fix icon creation logic

5221627

[Velopack] Remove Velopack lock file on next successful run

ac2342e

[Velopack] Suicide prevention hotline

673569d

Initially implement Customizable Toast Notification

4e6b9e7

Add option to not allocate console if app is already a console app

6ad9e0a

Add toast notification on launcher post-update

6715e02

Fix Zenless Cache Update status text

b3559c0

Due to unified Game Repair and Cache Update into a single base class, this causes the message from Game Repair to appear instead Cache Update ones

[skip ci] Sync translation Translate en_US.json in es_419

bd0a74b

100% reviewed source file: 'en_US.json' on 'es_419'.

[skip ci] Sync translation Translate en_US.json in zh_CN

09ae5e5

100% reviewed source file: 'en_US.json' on 'zh_CN'.

[PublishProfiles] Append DefineConstants to the new one

98ea476

[GitHub build CI] Add matrix config to the publish command

20763a5

[ILC] I guess we still need Reflection after all...

dbb5e9c

github-advanced-security bot found potential problems Dec 10, 2024

View reviewed changes

transifex-integration bot and others added 3 commits December 10, 2024 11:48

[skip ci] Sync translation Translate en_US.json in ja_JP

6612a18

100% reviewed source file: 'en_US.json' on 'ja_JP'.

Check for null Waifu2X instance

a4044f2

Inconsistent enable state?

[HTTP] Fix directory creation method in DownloadClient

d5488dd

Update SevenZipExtractor module for fix attempts

1d56b4f

bagusnl merged commit 626989f into preview Dec 11, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preview 1.82.5 Release #618

Preview 1.82.5 Release #618

bagusnl commented Dec 9, 2024 •

edited

Loading

sentry-io bot commented Dec 11, 2024

Preview 1.82.5 Release #618

Preview 1.82.5 Release #618

Conversation

bagusnl commented Dec 9, 2024 • edited Loading

What's new? - 1.82.5

Templates

sentry-io bot commented Dec 11, 2024

Suspect Issues

bagusnl commented Dec 9, 2024 •

edited

Loading