N°7793 Add breaking changes introduced by adding common SCSS variables between backoffice and end-user portal #675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Objective
This PR add the breaking changes that were explained in #674 but not added as it was on 3.2.x LTS branch
Proposed solution
All 'helpers'
$ibo-
variables now take their default values from a$common-
ancestor.That may lead to breaking changes in themes (see bf4de40 as an example).
From #674 description
Up until now
$ibo-
variables that inherited another$ibo-
variable value could be indirectly overloaded with a theme:But with how we envisioned the addition of
$common
variables, it would break the existing themes by breaking the link between$ibo-
variablesIn iTop 3.2.1 we'll keep this behavior and add a breaking change in iTop 3.3.0 that will require themes to either overload both
$ibo-
variables, or overload the$common-
variableChecklist before requesting a review