Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°7793 Add breaking changes introduced by adding common SCSS variables between backoffice and end-user portal #675

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

steffunky
Copy link
Member

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? N°7793
Type of change? Enhancement

Objective

This PR add the breaking changes that were explained in #674 but not added as it was on 3.2.x LTS branch

Proposed solution

All 'helpers' $ibo- variables now take their default values from a $common- ancestor.
That may lead to breaking changes in themes (see bf4de40 as an example).

From #674 description

Up until now $ibo- variables that inherited another $ibo- variable value could be indirectly overloaded with a theme:

Flow 1@1x-50fps

But with how we envisioned the addition of $common variables, it would break the existing themes by breaking the link between $ibo- variables
Flow 2@1x-50fps

In iTop 3.2.1 we'll keep this behavior and add a breaking change in iTop 3.3.0 that will require themes to either overload both $ibo- variables, or overload the $common- variable
Flow 3@1x-50fps

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

@steffunky steffunky changed the title N°7793 Add breaking changes induce by adding common SCSS variables between backoffice and end-user portal N°7793 Add breaking changes introduced by adding common SCSS variables between backoffice and end-user portal Nov 6, 2024
@steffunky steffunky requested a review from bdalsass November 7, 2024 10:42
@steffunky steffunky merged commit be5e445 into develop Nov 8, 2024
1 of 2 checks passed
@steffunky steffunky deleted the feature/7793_breaking_changes branch November 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants