Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°6663 - Request template fields do not apply portal silos #684

Open
wants to merge 3 commits into
base: support/3.2
Choose a base branch
from
Open

N°6663 - Request template fields do not apply portal silos #684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a86e3d4
N°6663 - Request template fields do not apply portal silos
accognet Nov 22, 2024
c2fc696
Better fix
accognet Nov 28, 2024
296ceb6
Better fix
accognet Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions sources/Renderer/Bootstrap/FieldRenderer/BsSelectObjectFieldRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
namespace Combodo\iTop\Renderer\Bootstrap\FieldRenderer;

use ApplicationContext;
use Combodo\iTop\Portal\Helper\ScopeValidatorHelper;
use Combodo\iTop\Renderer\RenderingOutput;
use ContextTag;
use CoreException;
Expand All @@ -29,6 +30,7 @@
use Exception;
use IssueLog;
use MetaModel;
use ModuleDesign;
use utils;

/**
Expand Down Expand Up @@ -103,8 +105,15 @@ public function Render()
$oOutput->AddHtml('<div class="col-xs-' . ( $this->oField->GetHierarchical() ? 10 : 12 ) . ' col-sm-' . ( $this->oField->GetHierarchical() ? 9 : 12 ) . ' col-md-' . ( $this->oField->GetHierarchical() ? 10 : 12 ) . '">');
$oOutput->AddHtml('<select id="' . $this->oField->GetGlobalId() . '" name="' . $this->oField->GetId() . '" class="form-control">');
$oOutput->AddHtml('<option value="">')->AddHtml(Dict::S('UI:SelectOne'), false)->AddHtml('</option>');
// - Retrieving choices
$oChoicesSet = new DBObjectSet($oSearch);

if (defined('PORTAL_ID'))
{
$oModuleDesign = new ModuleDesign(PORTAL_ID);
$oScopeValidatorHelper = new ScopeValidatorHelper( $oModuleDesign, PORTAL_ID);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$oScopeValidatorHelper = new ScopeValidatorHelper( $oModuleDesign, PORTAL_ID);
$oScopeValidatorHelper = new ScopeValidatorHelper($oModuleDesign, PORTAL_ID);

$oScopeValidatorHelper->AddScopeToQuery($oSearch, $oSearch->GetClass());
}

$oChoicesSet = new DBObjectSet($oSearch);
$oChoicesSet->OptimizeColumnLoad(array($oSearch->GetClassAlias() => array('friendlyname')));
while ($oChoice = $oChoicesSet->Fetch())
{
Expand Down