N°8031 - Make all portal bricks use custom templates for all templates #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdalsass
reviewed
Dec 17, 2024
datamodels/2.x/itop-portal-base/portal/src/Brick/AbstractBrick.php
Outdated
Show resolved
Hide resolved
datamodels/2.x/itop-portal-base/portal/src/Brick/BrickCollection.php
Outdated
Show resolved
Hide resolved
datamodels/2.x/itop-portal-base/portal/src/Brick/BrowseBrick.php
Outdated
Show resolved
Hide resolved
datamodels/2.x/itop-portal-base/portal/src/Brick/ObjectBrick.php
Outdated
Show resolved
Hide resolved
bdalsass
approved these changes
Dec 18, 2024
steffunky
added a commit
that referenced
this pull request
Dec 18, 2024
#691) * N°8031 - Make all portal bricks use custom templates for all templates * Rename parameter following code review * Add const variables following code review * Modify method name following code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Objective (enhancement)
With #686, we added a way to define a twig template for all Bricks without altering their definition. In this PR, we make bricks correctly collect, and use these custom twig templates.
This also adds a common way to define default templates for bricks and will be used to develop further brick template customization through its definition
Checklist before requesting a review