Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lenient DnsTest #474

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Conversation

armanbilge
Copy link
Contributor

No description provided.

val loopbacks = Set(ip"127.0.0.1", ip"::1")
Dns[IO].loopback.flatMap { loopback =>
IO(loopbacks.contains(clue(loopback)))
}
assertIO(Dns[IO].loopback.map(_.some), IpAddress.fromString("127.0.0.1"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to delete this line

@@ -43,13 +43,19 @@ class DnsTest extends CatsEffectSuite {
}

test("loopback") {
val loopbacks = Set(ip"127.0.0.1", ip"::1")
Dns[IO].loopback.flatMap { loopback =>
IO(loopbacks.contains(clue(loopback)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an assertion here?

@mpilquist mpilquist merged commit db9ce20 into Comcast:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants