Documentation and configuration updates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mbulfair
requested changes
Jun 13, 2018
package.json
Outdated
| @@ -28,6 +28,7 @@ | |||
| "Paul Wright <paul@paintedbicycle.com>" | |||
| ], | |||
| "scripts": { | |||
| "start": "npm run patternlab:serve", | |||
There was a problem hiding this comment.
This was removed on purpose to allow those who want to use yarn or npm. Also since it's just a hook to serve I felt it was not needed.
| `${plConfig.paths.source.patterns}**/*.md`, | ||
| `${plConfig.paths.source.data}**/*.json`, | ||
| `${plConfig.paths.source.patterns}**/*.(json|md|yaml|yml)`, | ||
| `${plConfig.paths.source.data}**/*.(json|md|yaml|yml)`, |
|
Updated |
mbulfair
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the minor cleanup of and addition to config entries for data and content files in the data folder and patterns, these are just suggested updates to documentation.