Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to hide version #7

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Allow to hide version #7

merged 3 commits into from
Feb 21, 2019

Conversation

akondas
Copy link
Contributor

@akondas akondas commented Feb 13, 2019

This PR add option --hide-version which allow to hide dependency version in generated file:

php-legal-licenses generate --hide-version

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2019

CLA assistant check
All committers have signed the CLA.

@@ -9,7 +9,7 @@ if (file_exists(__DIR__.'/../vendor/autoload.php')) {
require __DIR__.'/vendor/autoload.php';
}

$app = new Symfony\Component\Console\Application('PHP Legal Licenses', '1.1.0');
$app = new Symfony\Component\Console\Application('PHP Legal Licenses', '1.2.0');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to release 🚢

@ghost
Copy link

ghost commented Feb 21, 2019

Hi, what's the status of this PR? Could anyone review it, @orediggerco, @JohnRiv?

@orediggerco
Copy link
Member

Hey @marmichalski, reviewing your PR now!

Copy link
Member

@orediggerco orediggerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@orediggerco orediggerco merged commit c47a0ef into Comcast:master Feb 21, 2019
@orediggerco
Copy link
Member

Merged and added version v1.1.1. Thanks for your contribution, it's appreciated!

@akondas
Copy link
Contributor Author

akondas commented Feb 21, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants