Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixline numberissue #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixline numberissue #38

wants to merge 2 commits into from

Conversation

Dhanushkarthik29
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@radhi1991 radhi1991 requested review from dinpraka and sai100 September 5, 2024 06:18
@radhi1991 radhi1991 linked an issue Sep 5, 2024 that may be closed by this pull request
@@ -224,6 +224,8 @@ def format_detection(skeyword, org_url, url, code_content, secrets, skeyword_cou
else:
# Mask the current secret
masked_secret = mask_data(code_line, secret)
linenumber=findLineNumber(code_content.split("\n"),code_line)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename variable since it is is not the line number, rather a list of code lines, Also we can move this line to the utility function.

Copy link
Collaborator

@sai100 sai100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are appending the result of findLineNumber function, but we have no respective column in xgg_configs.yaml file for the secrets data columns.

Also please format the code using black formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add line number in detection csv file
3 participants