-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixline numberissue #38
base: main
Are you sure you want to change the base?
Conversation
|
@@ -224,6 +224,8 @@ def format_detection(skeyword, org_url, url, code_content, secrets, skeyword_cou | |||
else: | |||
# Mask the current secret | |||
masked_secret = mask_data(code_line, secret) | |||
linenumber=findLineNumber(code_content.split("\n"),code_line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename variable since it is is not the line number, rather a list of code lines, Also we can move this line to the utility function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are appending the result of findLineNumber function, but we have no respective column in xgg_configs.yaml file for the secrets data columns.
Also please format the code using black formatter.
No description provided.