Supports VHS video outputs in queue sidebar tab #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Oct 8, 2024
| @@ -213,7 +241,7 @@ export class TaskItemImpl { | |||
| : undefined | |||
| } | |||
|
|
|||
| public async loadWorkflow() { | |||
| public async loadWorkflow(app: ComfyApp) { | |||
There was a problem hiding this comment.
It's wield that if I don't import plainToClass from class transformer, vitest is throwing reflect-metadata not available error when import app.ts. I think it's time we just remove app.ts from the import list and accept it as a param from caller.
Unable to preview video (gif can be previewed normally)
The video URL is correct and can be played effectively,but in the sidebar, it says "Video failed to load"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1153
To test this PR:
video_queue_support.mp4