Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mask Editor #1284

Merged
merged 6 commits into from
Nov 18, 2024
Merged

New Mask Editor #1284

merged 6 commits into from
Nov 18, 2024

Conversation

trsommer
Copy link
Collaborator

New Features

  • Adjustable brush opacity and hardness settings
  • Updated interface to new comfyui styling
  • Redesigned tool panel positioned on the left side
  • Enhanced zooming capabilities:
    • Centered zoom control
    • Zoom to cursor position
  • Improved compatibility with touch screens and pen tablets
  • Line drawing tool (hold Shift + click)
  • Change brush size and hardness (hold Alt + left mouse Button hold + up/down or left/right)
  • Paint bucket tool for area fills
  • Undo/redo functionality
  • Hide Layers
  • Various bug fixes and performance improvements

Known Issues

  • Some TypeScript strict mode errors
  • Square brush hardness not yet implemented (currently defaults to circular brush)
  • top menus open behind the mask editor

image

image

image

@trsommer trsommer marked this pull request as draft October 23, 2024 22:07
@trsommer trsommer marked this pull request as ready for review November 10, 2024 05:11
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's implement this feature as an experimental feature that guarded behind a setting. Users can choose to enable this new editor in parallel with the old editor, so that if there is unseen bugs in the new editor, users still have a fallback.

@trsommer trsommer requested a review from huchenlei November 17, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants