Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #270 Improve error view #1617

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: #270 Improve error view #1617

merged 2 commits into from
Nov 20, 2024

Conversation

oto-ciulis-tt
Copy link
Collaborator

@oto-ciulis-tt oto-ciulis-tt commented Nov 20, 2024 •
edited
Loading

image

huchenlei
huchenlei requested changes Nov 20, 2024
View reviewed changes
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
huchenlei
huchenlei requested changes Nov 20, 2024
View reviewed changes
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
src/views/ServerStartView.vue Outdated Show resolved Hide resolved
huchenlei
huchenlei reviewed Nov 20, 2024
View reviewed changes
src/i18n.ts Outdated Show resolved Hide resolved
@otociulis @huchenlei
feat: #270 Improve error view
64f6dcf 
Reverting change

Lint & Format

PR comments

Fixing typo
@huchenlei huchenlei force-pushed the enh/improve-error-view branch from b671233 to 64f6dcf Compare November 20, 2024 21:28
@huchenlei
Copy link
Member

huchenlei commented Nov 20, 2024 •
edited
Loading

Some changes:

  • Button to single row
  • Button order change
  • Button style change
  • Add icon for open logs button
  • Report issue action changed to open forum (Was reported to sentry)
  • Rebased on top of [Electron] xterm startup logs #1620

image

@huchenlei huchenlei merged commit c857e7d into main Nov 20, 2024
9 checks passed
@huchenlei huchenlei deleted the enh/improve-error-view branch November 20, 2024 21:35
@robinjhuang robinjhuang mentioned this pull request Nov 24, 2024
Closed
@huchenlei huchenlei mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei requested changes

@robinjhuang robinjhuang Awaiting requested review from robinjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oto-ciulis-tt @huchenlei @otociulis