Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useless @ts-ignore and migrate to @ts-expect-error #293

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

tjx666
Copy link
Contributor

@tjx666 tjx666 commented Aug 4, 2024

This can also auto fixed by eslint.

Any idea to integrated eslint to this project?

@huchenlei
Copy link
Member

This can also auto fixed by eslint.

Any idea to integrated eslint to this project?

Going to setup eslint today. BTW, the content under src/scripts are gradually being rewritten, so it does not make much sense to fix the types / lint there.

Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei merged commit b5a919e into Comfy-Org:main Aug 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants