Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile history task items in queue store #389

Closed

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Aug 12, 2024

Before:

Selection_213

After:

Selection_212

Assumption is made that history items don't change in backend in a way that's meaningful to frontend.

As discussed in:

@huchenlei
Copy link
Member

@christian-byrne
Please take a look at #393. The queueIndex is strictly auto incrementing, so I think tracking the last seen queueIndex is sufficient for determine whether the item is new in the history queue.

@huchenlei huchenlei closed this Aug 12, 2024
@christian-byrne
Copy link
Collaborator Author

@christian-byrne Please take a look at #393. The queueIndex is strictly auto incrementing, so I think tracking the last seen queueIndex is sufficient for determine whether the item is new in the history queue.

Very nice, that makes it a lot smoother

Selection-001

@christian-byrne christian-byrne deleted the queue-reconcile branch August 13, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants