Fix reroute to wildcard & multi-typed slots #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same type check the rest of the connection process uses.
huchenlei
approved these changes
Sep 9, 2024
webfiltered
added a commit
to webfiltered/ComfyUI_frontend
that referenced
this pull request
Sep 13, 2024
Use the same type check the rest of the connection process uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Reroutes currently will not connect to nodes that do not exactly match their type.
The following result in silent auto-disconnects during
onConnectionsChangecallback:INTto*)INTnorINT,FLOATwill work withFLOAT,INT)INTtointNew behaviour
Use the same type check the rest of the connection process uses.