Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LiteGraph validation for node search->create #822

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Use LiteGraph validation for node search->create #822

merged 1 commit into from
Sep 13, 2024

Conversation

webfiltered
Copy link
Collaborator

Sometimes when dragging a connect to background and picking a new node, a connection would not be created. PR resolves (most of?) those cases.

  • Adds LiteGraph sig to augmentation.d.ts until LG types are auto-generated
  • Removes ts-expect-error

@webfiltered
Use LiteGraph validation for node search->create
bce5824 
Adds LiteGraph type to augmentation until LG types are auto-generated
Removes @ts-expect-error
@huchenlei huchenlei merged commit c98ea5b into Comfy-Org:main Sep 13, 2024
9 checks passed
@webfiltered webfiltered deleted the always-connect-searchcreate branch September 15, 2024 01:54
@huchenlei huchenlei mentioned this pull request Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei